New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer constraints against tuple fallbacks #4087

Merged
merged 4 commits into from Nov 15, 2017

Conversation

Projects
None yet
3 participants
@ilevkivskyi
Collaborator

ilevkivskyi commented Oct 9, 2017

Fixes #1485

Tuple fallback was overlooked in constraint inference. As usual, I place nominal before structural.

Show outdated Hide outdated mypy/constraints.py Outdated
@JukkaL

This comment has been minimized.

Show comment
Hide comment
@JukkaL

JukkaL Nov 15, 2017

Collaborator

Can you fix the merge conflict?

Collaborator

JukkaL commented Nov 15, 2017

Can you fix the merge conflict?

@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Nov 15, 2017

Collaborator

Fixed!

Appveyor failure is a flake.

Collaborator

ilevkivskyi commented Nov 15, 2017

Fixed!

Appveyor failure is a flake.

@JukkaL

JukkaL approved these changes Nov 15, 2017

LGTM, thanks for the fix!

@JukkaL JukkaL merged commit 67ff4cf into python:master Nov 15, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment