Infer constraints against tuple fallbacks #4087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daenyth
suggested changes
Oct 25, 2017
mypy/constraints.py
Outdated
| @@ -373,11 +373,12 @@ def visit_instance(self, template: Instance) -> List[Constraint]: | |||
| cb = infer_constraints(template.args[0], item, SUPERTYPE_OF) | |||
| res.extend(cb) | |||
| return res | |||
| elif isinstance(actual, TupleType) and self.direction == SUPERTYPE_OF: | |||
| return infer_constraints(template, actual.fallback, self.direction) | |||
| elif (isinstance(actual, TupleType) and template.type.is_protocol and | |||
There was a problem hiding this comment.
I don't see how this branch can ever be entered - when this condition is true, the condition of the branch above will be true, and this won't get entered.
There was a problem hiding this comment.
Yes, this branch is redundant now.
|
Can you fix the merge conflict? |
|
Fixed! Appveyor failure is a flake. |
JukkaL
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1485
Tuple fallback was overlooked in constraint inference. As usual, I place nominal before structural.