New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document empty tuple syntax #4313

Merged
merged 3 commits into from Dec 4, 2017

Conversation

Projects
None yet
4 participants
@ethanhs
Collaborator

ethanhs commented Dec 3, 2017

Fixes #4211.

@JelleZijlstra

This comment has been minimized.

Show comment
Hide comment
@JelleZijlstra

JelleZijlstra Dec 4, 2017

Collaborator

I'm not sure this belongs in the cheatsheet, since the cheatsheet is meant to be a quick reference for common types, and the type of an empty tuple is definitely not a common need. Maybe there isn't a better place for it though.

Collaborator

JelleZijlstra commented Dec 4, 2017

I'm not sure this belongs in the cheatsheet, since the cheatsheet is meant to be a quick reference for common types, and the type of an empty tuple is definitely not a common need. Maybe there isn't a better place for it though.

@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Dec 4, 2017

Collaborator

Maybe there isn't a better place for it though.

There is "Common issues" section. Maybe this discussion can be put there?

Collaborator

ilevkivskyi commented Dec 4, 2017

Maybe there isn't a better place for it though.

There is "Common issues" section. Maybe this discussion can be put there?

@JelleZijlstra

This comment has been minimized.

Show comment
Hide comment
@JelleZijlstra

JelleZijlstra Dec 4, 2017

Collaborator

I doubt it's a common issue either. :)

Maybe it should be in https://mypy.readthedocs.io/en/latest/builtin_types.html, which is currently missing Tuple.

Collaborator

JelleZijlstra commented Dec 4, 2017

I doubt it's a common issue either. :)

Maybe it should be in https://mypy.readthedocs.io/en/latest/builtin_types.html, which is currently missing Tuple.

@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Dec 4, 2017

Member

I think adding various forms of tuples to https://mypy.readthedocs.io/en/latest/builtin_types.html is a good idea, but I like adding this to the cheat sheets too (many people use just the cheat sheet for reference, and this is definitely an issue where everyone needs help).

Member

gvanrossum commented Dec 4, 2017

I think adding various forms of tuples to https://mypy.readthedocs.io/en/latest/builtin_types.html is a good idea, but I like adding this to the cheat sheets too (many people use just the cheat sheet for reference, and this is definitely an issue where everyone needs help).

ethanhs and others added some commits Dec 4, 2017

@gvanrossum gvanrossum merged commit 71332d5 into python:master Dec 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ethanhs ethanhs deleted the ethanhs:emptytuple branch Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment