report columns in 1-based, not 0-based

[elliott-beach]

fixes #4475

[gvanrossum]

Any reason why you're not just inlining column + 1 here?

[elliott-beach]

My thinking was doing math inside format string is awkward, but I have no strong opinion.

…

On Wed, Jan 17, 2018 at 8:12 PM Guido van Rossum ***@***.***> wrote: ***@***.**** approved this pull request. ------------------------------ In mypy/errors.py <#4482 (comment)>: > @@ -411,7 +411,8 @@ def format_messages(self, error_info: List[ErrorInfo]) -> List[str]: if file is not None: if self.show_column_numbers and line is not None and line >= 0 \ and column is not None and column >= 0: - srcloc = '{}:{}:{}'.format(file, line, column) + col = 1 + column + srcloc = '{}:{}:{}'.format(file, line, col) Any reason why you're not just inlining column + 1 here? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4482 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANBOAiBqgQHb2evN5sAe2kb6xNk3jnQyks5tLqhygaJpZM4RiPDn> .

[gvanrossum]

No good deed goes unpunished, flake8 wants spaces around the +.

[gvanrossum]

Thanks!