-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Make TypeIndirectionVisitor depend on all classes in MROs #4566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you understand why the tests fail on all builds except 3.6? |
I've restarted the build, but it doesn't feel like a glitch. (There have been some glitches related to Trusty.) |
After re-running the failing build, it still fails, but now with 3 out of 4 jobs passing (previously only 3.6 passed). But 3.4 still fails, even after re-running that one. Flake? Or something else? |
I am deeply confused by this. |
I can intermittently reproduce the failure locally---it seems to genuinely be a nondeterministic failure. I am investigating. |
The test failures were caused by #4568 is up to fix that. I'm rebasing this diff but it needs to not land until the other has. |
e2b76b9
to
1cc3848
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can merge both PRs when ready (if testpr
is clean).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for digging deeper!
This fixes some nasty incremental mode bugs. Fixes #4562.
0ea84ed
to
0abf442
Compare
This fixes some nasty incremental mode bugs. Fixes python#4562.
This fixes some nasty incremental mode bugs.
Fixes #4562.