New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TypeIndirectionVisitor depend on all classes in MROs #4566

Merged
merged 1 commit into from Feb 14, 2018

Conversation

Projects
None yet
3 participants
@msullivan
Collaborator

msullivan commented Feb 12, 2018

This fixes some nasty incremental mode bugs.
Fixes #4562.

@msullivan msullivan requested a review from gvanrossum Feb 12, 2018

@gvanrossum

This comment has been minimized.

Member

gvanrossum commented Feb 12, 2018

Can you understand why the tests fail on all builds except 3.6?

@gvanrossum

This comment has been minimized.

Member

gvanrossum commented Feb 12, 2018

I've restarted the build, but it doesn't feel like a glitch. (There have been some glitches related to Trusty.)

@gvanrossum

This comment has been minimized.

Member

gvanrossum commented Feb 12, 2018

After re-running the failing build, it still fails, but now with 3 out of 4 jobs passing (previously only 3.6 passed). But 3.4 still fails, even after re-running that one. Flake? Or something else?

@msullivan

This comment has been minimized.

Collaborator

msullivan commented Feb 13, 2018

I am deeply confused by this.

@msullivan

This comment has been minimized.

Collaborator

msullivan commented Feb 13, 2018

I can intermittently reproduce the failure locally---it seems to genuinely be a nondeterministic failure. I am investigating.

@msullivan

This comment has been minimized.

Collaborator

msullivan commented Feb 13, 2018

The test failures were caused by STRICT_OPTIONAL leaking out and being true for unit tests. This would happen if a test run under dmypy had strict optional on (and I added a test that did). It was nondeterministic because it only came up if the same runner that ran that test then ran the typing unit tests.

#4568 is up to fix that. I'm rebasing this diff but it needs to not land until the other has.

@ilevkivskyi

I think you can merge both PRs when ready (if testpr is clean).

@gvanrossum

Thanks for digging deeper!

Make TypeIndirectionVisitor depend on all classes in MROs
This fixes some nasty incremental mode bugs.
Fixes #4562.

@msullivan msullivan merged commit c25dd08 into master Feb 14, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@msullivan msullivan deleted the incremental-bustage branch Feb 14, 2018

yedpodtrzitko added a commit to kiwicom/mypy that referenced this pull request Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment