Skip to content

Make TypeIndirectionVisitor depend on all classes in MROs #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

msullivan
Copy link
Collaborator

This fixes some nasty incremental mode bugs.
Fixes #4562.

@msullivan msullivan requested a review from gvanrossum February 12, 2018 18:54
@gvanrossum
Copy link
Member

Can you understand why the tests fail on all builds except 3.6?

@gvanrossum
Copy link
Member

I've restarted the build, but it doesn't feel like a glitch. (There have been some glitches related to Trusty.)

@gvanrossum
Copy link
Member

After re-running the failing build, it still fails, but now with 3 out of 4 jobs passing (previously only 3.6 passed). But 3.4 still fails, even after re-running that one. Flake? Or something else?

@msullivan
Copy link
Collaborator Author

I am deeply confused by this.

@msullivan
Copy link
Collaborator Author

I can intermittently reproduce the failure locally---it seems to genuinely be a nondeterministic failure. I am investigating.

@msullivan
Copy link
Collaborator Author

The test failures were caused by STRICT_OPTIONAL leaking out and being true for unit tests. This would happen if a test run under dmypy had strict optional on (and I added a test that did). It was nondeterministic because it only came up if the same runner that ran that test then ran the typing unit tests.

#4568 is up to fix that. I'm rebasing this diff but it needs to not land until the other has.

@msullivan msullivan force-pushed the incremental-bustage branch 2 times, most recently from e2b76b9 to 1cc3848 Compare February 13, 2018 08:58
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can merge both PRs when ready (if testpr is clean).

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging deeper!

This fixes some nasty incremental mode bugs.
Fixes #4562.
@msullivan msullivan merged commit c25dd08 into master Feb 14, 2018
@msullivan msullivan deleted the incremental-bustage branch February 14, 2018 20:16
yedpodtrzitko pushed a commit to kiwicom/mypy that referenced this pull request Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False negative in incremental mode
3 participants