New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly format Callables in stubgen #4650

Merged
merged 3 commits into from Mar 27, 2018

Conversation

Projects
None yet
3 participants
@evhub
Contributor

evhub commented Feb 28, 2018

Resolves #4638/#4640.

@@ -65,7 +65,7 @@
from mypy.stubgenc import parse_all_signatures, find_unique_signatures, generate_stub_for_c_module
from mypy.stubutil import is_c_module, write_header
from mypy.options import Options as MypyOptions
from mypy.types import Type, TypeStrVisitor, AnyType, CallableType, UnboundType, NoneTyp, TupleType
from mypy.types import Type, TypeStrVisitor, AnyType, CallableType, UnboundType, NoneTyp, TupleType, TypeList

This comment has been minimized.

@ethanhs

ethanhs Feb 28, 2018

Collaborator

This line is too long. You probably should use a multi-line import.

@ethanhs

This comment has been minimized.

Collaborator

ethanhs commented Feb 28, 2018

@evhub thanks for working on this. Could you add some tests please? Definitely any minimal reproductions in the original issues, but also just a few common/more complex example tests of what was broken/solved. Thanks again!

@ethanhs

LGTM.

@gvanrossum gvanrossum merged commit 4b82636 into python:master Mar 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment