New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set python_version to default to sys.version_info #4686

Merged
merged 2 commits into from Mar 6, 2018

Conversation

Projects
None yet
2 participants
@ethanhs
Collaborator

ethanhs commented Mar 6, 2018

This sets the default Python version used for type checking to sys.version_info.

Fixes #4620.

The design of this is such that we set tests to default to the running Python whenever possible, but modify tests that use new syntax and libraries to run on Python 3.5 or 3.6.

Example output of failing tests on 3.4 before test changes https://gist.github.com/ethanhs/f782bec70eab0678d9e869465b40a571#file-output-log-L512.

This was split out of #4403

ethanhs added some commits Mar 6, 2018

@ethanhs ethanhs changed the title from [WIP]Set python_version to default to sys.version_info to Set python_version to default to sys.version_info Mar 6, 2018

@gvanrossum gvanrossum merged commit 621b7d3 into python:master Mar 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

yedpodtrzitko added a commit to kiwicom/mypy that referenced this pull request Mar 15, 2018

Set python_version to default to sys.version_info (python#4686)
This sets the default Python version used for type checking to `sys.version_info`.

Fixes python#4620.

The design of this is such that we set tests to default to the running Python whenever possible, but modify tests that use new syntax and libraries to run on Python 3.5 or 3.6.

Example output of failing tests on 3.4 before test changes https://gist.github.com/ethanhs/f782bec70eab0678d9e869465b40a571#file-output-log-L512.

This was split out of python#4403.

@ethanhs ethanhs deleted the ethanhs:sysdefaultver branch Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment