New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce stubgen into emiting `Any` type annotations for un-annotated args #4774

Merged
merged 1 commit into from Apr 4, 2018

Conversation

Projects
None yet
5 participants
@mgilson
Contributor

mgilson commented Mar 21, 2018

This fixes #4766.

Previously, stubgen would leave un-annotated function arguments. This change now causes Any to be emitted if no other type information is present. The reason is that it allows running mypy --strict against the generated stubs.

@gvanrossum

LGTM. @JukkaL What do you think of this idea? (I think the execution is fine.)

@ilevkivskyi

FWIW, I like the idea. Probably because explicit is better than implicit.

@msullivan msullivan merged commit 0185436 into python:master Apr 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment