Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Removes incorrect override check on overloaded methods #4810
This commit fixes #4565
Currently, when we override a method and annotate the implementation, mypy appears to check the legality of the override twice: once for the overloads, and once for the implementation.
This second check is unnecessary and causes a spurious error.
ilevkivskyi left a comment
I would actually add a test where overloaded types are actually incompatible and this generates "Incompatible with supertype error". It looks like we only have few such tests for stubs, not for source files where implementation is required.