Fix operator access on Type[...] #4823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2018 11:08
|
@JukkaL My understanding is that @msullivan wants to move the typeshed pin before Tuesday when you are back, so I am not waiting for your review (PR is quite straightforward), but if there is something bad please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4789
This also fixes typeshed problems in internal codebases.
The idea is straightforward add overlooked
elif. A better long-term solution may be to refactorhas_memberto usecheckmember.analyze_member_access.I use
pythonevaltests because the original problem only appears currently with full stubs (apparently becauseintdoesn't have operator methods in fixtures).