New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operator access on Type[...] #4823

Merged
merged 2 commits into from Mar 29, 2018

Conversation

Projects
None yet
2 participants
@ilevkivskyi
Collaborator

ilevkivskyi commented Mar 29, 2018

Fixes #4789
This also fixes typeshed problems in internal codebases.

The idea is straightforward add overlooked elif. A better long-term solution may be to refactor has_member to use checkmember.analyze_member_access.

I use pythoneval tests because the original problem only appears currently with full stubs (apparently because int doesn't have operator methods in fixtures).

Ivan Levkivskyi added some commits Mar 29, 2018

@ilevkivskyi ilevkivskyi requested a review from JukkaL Mar 29, 2018

@msullivan

LGTM

@ilevkivskyi

This comment has been minimized.

Collaborator

ilevkivskyi commented Mar 29, 2018

@JukkaL My understanding is that @msullivan wants to move the typeshed pin before Tuesday when you are back, so I am not waiting for your review (PR is quite straightforward), but if there is something bad please let me know.

@ilevkivskyi ilevkivskyi merged commit 5773c4e into python:master Mar 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:fix-type-ops branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment