Fix stubgen --recursive to only generate stubs for requested submodules. #4845
Conversation
mgilson
force-pushed
the
stubgen-recursive/4844
branch
from
34ae6c6 to
cf02970
Compare
mypy/stubgen.py
Outdated
| path = getattr(package, '__path__', None) | ||
| if path is None: | ||
| # It's a module inside a package. There's nothing else to walk/yield. | ||
| return |
There was a problem hiding this comment.
Use continue here, there may be more packages in the packages argument list, we want to process all of them.
There was a problem hiding this comment.
Yep, thanks. Somehow I failed to notice the outer loop.
|
Unit tests for stubgen are in mypy/test/teststubgen.py, but don't sweat it.
|
|
This LGTM -- were you going to try and add a test or not? Let me know. |
This also adds a place to do unit-testing on other utility functions for the stubgen CLI. The general idea here is to test `walk_packages` against `mypy` itself since (presumably) is is already imported or will be imported during the tests. We should also know the exact module structure (unlike something like `urllib` that changes depending on python2.x and python3.x). I tried not to make the test too prescriptive to reduce the chances that it will need to be updated when new modules or subpackages are added to `mypy`.
|
I've added a test. I don't really know the best way to test something that relies on Anyway, let me know if you think this is a bad way to go about testing this utility function. |
|
This looks like a good start -- thanks for going the extra mile! I'm merging it now. |
This fixes #4844
I'm not completely sure where/how to add unit tests for this. I'm happy to do that if someone can point me in the right direction though.
As it stands, I have tested this manually against
urllibandurllib.parseand verified that the current code only generatesout/urllib/parse.pyiin the latter case but generates all the stubs forurllibin the former case.