Allow incompatible overriding of __slots__ #4890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`__slots__` is magic and there's no need for subclasses to have compatible definitions.
| @@ -4296,3 +4299,13 @@ class C: pass | |||
|
|
|||
| @undefined # E: Name 'undefined' is not defined | |||
| class D: pass | |||
|
|
|||
| [case testSlotsCompatibility] | |||
There was a problem hiding this comment.
Should we test that there is still an error if we set __slots__ to something nonsensical like an int?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__slots__is magic and there's no need for subclasses to havecompatible definitions.