Reprocess decorators instead of the function they decorate #4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where decorators on overloaded methods would sometimes report false positives.
JukkaL
reviewed
May 2, 2018
There was a problem hiding this comment.
LGTM. It seems that now we type check the decorator expressions both when type checking the surrounding target and when type checking the decorated function, but I don't see why this would be a problem.
Before merging, I'd suggest considering an alternative, perhaps slightly simpler approach of adding a flag to decorated FuncDefs that will cause the method override check to be skipped.
|
Good call. Done. |
|
Oh, darn. I didn't fix the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where decorators on overloaded methods
would sometimes report false positives.