Do not serialize symbol table nodes added by 'add_submodules_to_parent_modules' #5094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
May 22, 2018
| 'implicit', | ||
| 'is_aliasing', | ||
| 'alias_name', | ||
| 'no_serialize' |
There was a problem hiding this comment.
Trailing comma. Also add a comment to the end of the docstring about it please.
There was a problem hiding this comment.
Sorry, already merged before seeing your comment. Will fix this later.
ilevkivskyi
added a commit
that referenced
this pull request
May 22, 2018
…t_modules' (#5094) A hot fix for a complicated crash due to a poisoned cache (discovered internally).
msullivan
added a commit
that referenced
this pull request
May 23, 2018
It looks like what happened is that since d.k.e doesn't exist, d.k.v doesn't depend on d or d.k. However, it still performs parent patching on them. Since there isn't a dependency, this can occur *before* d is processed, which causes the parent patched symbol table entries to be present when serialization occurs. This causes bogus cache entries to be written.
msullivan
added a commit
that referenced
this pull request
May 24, 2018
It looks like what happened is that since d.k.e doesn't exist, d.k.v doesn't depend on d or d.k. However, it still performs parent patching on them. Since there isn't a dependency, this can occur *before* d is processed, which causes the parent patched symbol table entries to be present when serialization occurs. This causes bogus cache entries to be written.
ilevkivskyi
pushed a commit
to ilevkivskyi/mypy
that referenced
this pull request
May 24, 2018
gvanrossum
pushed a commit
that referenced
this pull request
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hot fix for a complicated crash due to a poisoned cache (discovered internally).