Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix crash in astdiff.py related to ec11a500f. #5126
I had been seeing the same crash that patch aimed to fix running against Quip's
Traceback from crash after ec11a50:
File "/usr/local/lib/python3.6/site-packages/mypy/server/update.py", line 760, in propagate_changes_using_dependencies
I'm going to merge this because I believe it to be likely to do more good than harm, though I haven't been able to track down a testcase.
Part of the reason I'm willing to do this is that I think that it probably isn't actually necessary for
That is a bigger change, though, and I'm more willing to cherry-pick this one, so I'm going to do that and follow-up on it later.