Update stubutil.py is_c_module with .pyd check #5284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check for .pyd file extension used on Windows
gvanrossum
reviewed
Jun 27, 2018
mypy/stubutil.py
Outdated
| @@ -87,7 +87,8 @@ def find_unique_signatures(sigs: Sequence[Sig]) -> List[Sig]: | |||
|
|
|||
|
|
|||
| def is_c_module(module: ModuleType) -> bool: | |||
| return '__file__' not in module.__dict__ or module.__dict__['__file__'].endswith('.so') | |||
| return '__file__' not in module.__dict__ or any(module.__dict__['__file__'].endswith( | |||
| ext) for ext in ['.so', '.pyd']) | |||
There was a problem hiding this comment.
This is causing the linter to fail:
./mypy/stubutil.py:91:7: E121 continuation line under-indented for hanging indent
You can run the linter locally: flake8 mypy/stubutil.py
Though honestly I would refactor the code a little more -- the any() feels like it makes the code more complex than it needs to be. Maybe use os.path.splitext()?
Use os.path.splitext instead of str.endswith and breaking long line properly
|
Thanks, Guido! I did not dare to refactor, but thanks for the hint, it is done, the linter should be happy now. Please review the latest changes and let me know if there is anything more that should be fixed. |
|
Thanks Alex! That was actually exactly the refactoring I was thinking of. :-) |
|
i dont understand how didi u generate pyi file for pyd python file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for .pyd file extension used on Windows