New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and store fallbacks for incomplete named tuples #5429

Merged
merged 1 commit into from Aug 8, 2018

Conversation

Projects
None yet
2 participants
@ilevkivskyi
Collaborator

ilevkivskyi commented Aug 7, 2018

Fixes #4287

Previously, incomplete named tuple definition could result in broken TypeInfo that could lead to bugs and crashes. Now we store a correct type even for incomplete definitions.

@ilevkivskyi ilevkivskyi requested a review from msullivan Aug 7, 2018

@msullivan

Looks good!

@msullivan msullivan merged commit 05f878d into python:master Aug 8, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment