Add path expansion for write_junit_xml output argument

[EvanKepner]

Hi - this is a small addition to allow the --junit-xml arg to accept a string path as well as a file.

Example:

$ mypy file1.py --junit-xml=a.xml

$ mypy file1.py --junit.xml "this/is/a/test.xml"
$ tree this/
this/
└── is
    └── a
        └── test.xml

2 directories, 1 file

[gvanrossum]

Calling makedirs makes some sense, but user expansion doesn’t.

[EvanKepner]

Thanks for the review - I included the user expansion to catch cases of ~ in the path e.g. both ~/outputs/file.xml and $HOME/outputs/file.xml are valid path entries where the first is caught by the user expansion, and the latter is caught by the variable expansion. If you'd still like the removal of user expansion let me know and I'll commit the change. If user expansion is removed, then the --junit-xml=~/outputs/file.xml is created in the cwd as /your/cwd/~/outputs/file.xml.

[gvanrossum]

You can write --junit-xml ~/outputs/file.xml, so there is no need to expand ~/. Please commit the change.

[EvanKepner]

Thanks for the guidance - in my testing I was passing in the argument as a string with quotes which was my error, when I pass in the argument without the string quotes it operates as expected without the expand-user. Commit made, appreciate the review!

[msullivan]

I think we probably don't want expandvars either. Shells will do this for us, and we don't do it for any other filenames.

[gvanrossum]

I think we probably don't want expandvars either. Shells will do this for us, and we don't do it for any other filenames.

Indeed, that's what I meant, sorry.

[EvanKepner]

No problem at all, changes made.

[gvanrossum]

Thanks!

[EvanKepner]

Absolutely, thanks for the feedback and accepting!