New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge --add into --update for daemon #5840

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
2 participants
@ilevkivskyi
Copy link
Collaborator

ilevkivskyi commented Oct 25, 2018

This simplifies some logic in code and also is easier to use. I tested this manually and it seem to work well.

@ilevkivskyi ilevkivskyi requested a review from gvanrossum Oct 25, 2018

@gvanrossum
Copy link
Member

gvanrossum left a comment

Looks good!

@gvanrossum

This comment has been minimized.

Copy link
Member

gvanrossum commented Oct 25, 2018

@msullivan Wait for this with any pin moves please.

@ilevkivskyi ilevkivskyi merged commit 14583b7 into python:master Oct 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:merge-daemon-add branch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment