Skip to content

Merge --add into --update for daemon #5840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2018
Merged

Merge --add into --update for daemon #5840

merged 1 commit into from
Oct 26, 2018

Conversation

ilevkivskyi
Copy link
Member

This simplifies some logic in code and also is easier to use. I tested this manually and it seem to work well.

gvanrossum
gvanrossum approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gvanrossum
Copy link
Member

gvanrossum commented Oct 25, 2018 •
edited
Loading

@msullivan Wait for this with any pin moves please.

@ilevkivskyi ilevkivskyi merged commit 14583b7 into python:master Oct 26, 2018
@ilevkivskyi ilevkivskyi deleted the merge-daemon-add branch October 26, 2018 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilevkivskyi @gvanrossum