New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ctypes plugin trying to look up bytes in Python 2 #5924

Merged
merged 2 commits into from Nov 20, 2018

Conversation

Projects
None yet
2 participants
@dgelessus
Copy link
Contributor

dgelessus commented Nov 20, 2018

Fixes #5922.

dgelessus added some commits Nov 20, 2018

Split floatdict.pyi fixture into Python 2 and 3 variants
This is because bytes should only be defined in Python 3, and unicode
should only be defined in Python 2. sys.version checks don't work in
test fixtures, so the only way to implement this is to split the
fixture into two separate files.
@ilevkivskyi
Copy link
Collaborator

ilevkivskyi left a comment

Thanks for the quick fix! LGTM.

@ilevkivskyi ilevkivskyi merged commit 7819cff into python:master Nov 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment