New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve tabs when creating XML reports (#5942) #5945

Merged
merged 1 commit into from Nov 24, 2018

Conversation

Projects
None yet
2 participants
@mthuurne
Copy link
Contributor

mthuurne commented Nov 23, 2018

Control characters are replaced with question marks, to avoid
outputting invalid XML. However, XML does allow tabs in content,
so make an exception for those.

@gvanrossum
Copy link
Member

gvanrossum left a comment

Can you update the test also please? It's testClassDefIsTreatedAsEmpty in test-data/unit/reports.test.

Preserve tabs when creating XML reports (#5942)
Control characters are replaced with question marks, to avoid
outputting invalid XML. However, XML does allow tabs in content,
so make an exception for those.

@mthuurne mthuurne force-pushed the mthuurne:preserve_tabs_in_reports branch from 9ab0c3c to 499fb2e Nov 23, 2018

@mthuurne

This comment has been minimized.

Copy link
Contributor

mthuurne commented Nov 23, 2018

I added a tab in the test case you mentioned and changed the expected output accordingly.

@gvanrossum gvanrossum merged commit dec6004 into python:master Nov 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment