Short-circuit if expression for always true/always false vars and MYPY/TYPE_CHECKING
#5965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't run or tested this locally yet, I'll do that tomorrow :o) |
samertm
force-pushed
the
shortcircuit
branch
from
b86b2ec to
0b64679
Compare
msullivan
approved these changes
Dec 13, 2018
samertm
force-pushed
the
shortcircuit
branch
2 times, most recently
from
6a2587f to
a00906d
Compare
|
Just fixed the merge conflicts, should be ready to merge if the tests pass. |
|
Unfortunately they did not |
samertm
force-pushed
the
shortcircuit
branch
from
a00906d to
268b99c
Compare
…YPY/TYPE_CHECKING - Always short-circuit in the if's expression, instead of only short-circuiting for "ALWAYS_TRUE/FALSE" constants (e.g. sys.platform checks) and not "MYPY_TRUE/FALSE" constants (e.g. `MYPY`) - Make --always-true and --always-false map to ALWAYS_TRUE and ALWAYS_FALSE, respectively, instead of MYPY_TRUE and MYPY_FALSE. The only difference between the two is a change in import priority, but semantically uses of "--always-true" are probably closer to "this condition should be true at compile time and runtime" than "this condition should be true at compile time but false at runtime". - Fixes python#5963
samertm
force-pushed
the
shortcircuit
branch
from
268b99c to
dd63fcb
Compare
|
Looks like tests are passing now :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always short-circuit in the if's expression, instead of only
short-circuiting for "ALWAYS_TRUE/FALSE" constants (e.g. sys.platform
checks) and not "MYPY_TRUE/FALSE" constants (e.g.
MYPY)Make --always-true and --always-false map to ALWAYS_TRUE and
ALWAYS_FALSE, respectively, instead of MYPY_TRUE and MYPY_FALSE.
The only difference between the two is a change in import priority,
but semantically uses of "--always-true" are probably closer to
"this condition should be true at compile time and runtime" than
"this condition should be true at compile time but false at
runtime".
Fixes Small bug:
ifexpression doesn't short circuit for --always-false/--always-true #5963