New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new, hidden window when starting daemon on Windows #5994

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@ethanhs
Copy link
Collaborator

ethanhs commented Dec 3, 2018

Fixes #5991

Basically grandchildren could allocate new consoles, which we were somewhere. This changes things so we create a new console (which seems to detach us from the parent process...) but we create it hidden, so that it is invisible. For more, and the source for the solution, you might want to read python/cpython#4150 (comment).

@ethanhs ethanhs requested review from msullivan and Michael0x2a Dec 3, 2018

@Michael0x2a
Copy link
Collaborator

Michael0x2a left a comment

I tried running this, and can confirm it fixes the problem -- thanks for the super-quick turnaround!

@ethanhs ethanhs merged commit 288b6bb into python:master Dec 3, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ethanhs ethanhs deleted the ethanhs:windmypyhide branch Dec 3, 2018

@ethanhs

This comment has been minimized.

Copy link
Collaborator

ethanhs commented Dec 3, 2018

You're welcome! It was definitely something I wanted to look into, but it never really bothered me that much. But now that I fixed it I could never go back :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment