New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add star imported modules as dependencies #6179

Merged
merged 2 commits into from Jan 11, 2019

Conversation

Projects
None yet
2 participants
@ilevkivskyi
Copy link
Collaborator

ilevkivskyi commented Jan 10, 2019

Fixes #6110

I tried few approaches, and this one seems the most clean to me. Essentially, we just add some more imports (dependencies) after the second pass, where the star imports are resolved.

@ilevkivskyi ilevkivskyi requested review from JukkaL , msullivan and gvanrossum Jan 10, 2019

@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator Author

ilevkivskyi commented Jan 10, 2019

(I manually verified that this fixes the mypy crashes discovered in our internal codebases.)

Ivan Levkivskyi
@msullivan
Copy link
Collaborator

msullivan left a comment

This seems basically reasoanble.

@msullivan msullivan merged commit e6f111a into python:master Jan 11, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:fix-star-import-crash branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment