Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move message constants to mypy.message_registry #6194

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
2 participants
@chadrik
Copy link
Contributor

commented Jan 15, 2019

This is the next step toward message filtering (#2417), and a precursor to PR #6152.

By moving constants to their own module we can easily inspect them to get both their name and value, for use within a message filtering system.

Move message constants to mypy.message_registry
This is in preparation for message filtering
@JukkaL

JukkaL approved these changes Jan 15, 2019

Copy link
Collaborator

left a comment

Thanks, looks good! This will allow a cleaner implementation of message ids.

@JukkaL JukkaL merged commit cdfca4f into python:master Jan 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.