Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stubgen mypyc type mismatch #6642

Merged
merged 1 commit into from Apr 6, 2019

Conversation

Projects
None yet
2 participants
@msullivan
Copy link
Collaborator

commented Apr 6, 2019

find_module_path_and_all_py3 promises to return __all__ as a List, but
__all__ could be a tuple or something. Make sure to convert it.

Fixes #6639.

@msullivan msullivan requested a review from ilevkivskyi Apr 6, 2019

Fix stubgen mypyc type mismatch
find_module_path_and_all_py3 promises to return __all__ as a List, but
__all__ could be a tuple or something. Make sure to convert it.

Fixes #6639.

@msullivan msullivan force-pushed the fix-stubgen-crash branch from f45da48 to 4bde5d0 Apr 6, 2019

@ilevkivskyi
Copy link
Collaborator

left a comment

Thanks for quick fix!

@msullivan msullivan merged commit 486e4d7 into master Apr 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msullivan msullivan deleted the fix-stubgen-crash branch Apr 6, 2019

This was referenced Apr 11, 2019

msullivan added a commit that referenced this pull request Apr 15, 2019

Fix stubgen mypyc type mismatch (#6642)
find_module_path_and_all_py3 promises to return __all__ as a List, but
__all__ could be a tuple or something. Make sure to convert it.

Fixes #6639.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.