Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix __getattr__ and operators related infinite recursion #6655

Merged
merged 2 commits into from
Apr 11, 2019

Conversation

onlined
Copy link
Contributor

@onlined onlined commented Apr 10, 2019

Fixes #6579.

mypy/checkexpr.py Outdated Show resolved Hide resolved
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@ilevkivskyi ilevkivskyi merged commit 94746d6 into python:master Apr 11, 2019
nanshu pushed a commit to nanshu/mypy that referenced this pull request Aug 14, 2020
nanshu pushed a commit to nanshu/mypy that referenced this pull request Aug 14, 2020
1. limit the version of the test deps in test-requirements.txt by release data (i.e. Jan 16 2019, when v0.660 was released)
2. ./runtests.py and all tests pass
3. add tests from python#6655 and python#7446 and ./runtests.py and new test cases fail
4. apply changes from python#6655 and python#7446 manually
5. run tests and all pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants