Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataclass plugin interaction with member expressions #6739

Merged
merged 2 commits into from Apr 30, 2019

Conversation

@ilevkivskyi
Copy link
Collaborator

commented Apr 29, 2019

Fixes #6516

It also fixes minor corner case that affects tests cases proposed in the issue.

@JukkaL

JukkaL approved these changes Apr 30, 2019

Copy link
Collaborator

left a comment

LGTM, just one nit.

mypy/plugins/dataclasses.py Outdated Show resolved Hide resolved
Ivan Levkivskyi

@ilevkivskyi ilevkivskyi merged commit e8a72a0 into python:master Apr 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:fix-dataclasses-field branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.