Skip to content

Fix dataclass plugin interaction with member expressions #6739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2019
Merged

Fix dataclass plugin interaction with member expressions #6739

merged 2 commits into from
Apr 30, 2019

Conversation

ilevkivskyi
Copy link
Member

Fixes #6516

It also fixes minor corner case that affects tests cases proposed in the issue.

@ilevkivskyi ilevkivskyi mentioned this pull request Apr 29, 2019
Closed
@ilevkivskyi ilevkivskyi requested review from JukkaL and msullivan April 29, 2019 23:51
JukkaL
JukkaL approved these changes Apr 30, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

@ilevkivskyi ilevkivskyi merged commit e8a72a0 into python:master Apr 30, 2019
@ilevkivskyi ilevkivskyi deleted the fix-dataclasses-field branch April 30, 2019 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

@msullivan msullivan Awaiting requested review from msullivan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect "Attributes without a default cannot follow attributes with one" in dataclasses
2 participants
@ilevkivskyi @JukkaL