Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show closest candidates for misspellings: from..import case #6778

Merged

Conversation

@marcodoordash
Copy link
Contributor

commented May 6, 2019

This fixes the following case outlined in #824:

from subprocess import popen  # Module 'subprocess' has no attribute 'popen'

is now

from subprocess import popen  # Module 'subprocess' has no attribute 'popen'; maybe "Popen"?

@marcodoordash marcodoordash reopened this May 6, 2019

@marcodoordash marcodoordash changed the title Show closest candidates for misspellings: from..import case [WIP] [issues/824] Show closest candidates for misspellings: from..import case [WIP] May 6, 2019

@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

Please let us know when this is no more [WIP].

@marcodoordash marcodoordash changed the title [issues/824] Show closest candidates for misspellings: from..import case [WIP] [issues/824] Show closest candidates for misspellings: from..import case May 6, 2019

@marcodoordash

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

@ilevkivskyi ready for review, could not add you as a reviewer

@ilevkivskyi
Copy link
Collaborator

left a comment

Thanks! I have just couple formatting suggestions. Fix them and I will merge when tests pass in CI.

mypy/newsemanal/semanal.py Outdated Show resolved Hide resolved
mypy/semanal.py Outdated Show resolved Hide resolved

ilevkivskyi and others added some commits May 6, 2019

Updating based on suggestion
Co-Authored-By: marcodoordash <44383269+marcodoordash@users.noreply.github.com>
Updating based on suggestion
Co-Authored-By: marcodoordash <44383269+marcodoordash@users.noreply.github.com>

@ilevkivskyi ilevkivskyi changed the title [issues/824] Show closest candidates for misspellings: from..import case Show closest candidates for misspellings: from..import case May 6, 2019

@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

@marcodoordash There are still two failures in CI:

  • You forgot to update the new semantic analyzer test output in one test.
  • Self-type-check failed.
@marcodoordash

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

@ilevkivskyi sorry I am on my way to the airport right now, won't be able to look at it before a couple of hours at least.

@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

won't be able to look at it before a couple of hours at least.

Don't worry, just wanted to let you know.

marcodoordash added some commits May 6, 2019

@marcodoordash

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

@ilevkivskyi all fixed

@ilevkivskyi ilevkivskyi merged commit f0551a8 into python:master May 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.