Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip error if attribute or method is private to class #6790

Merged

Conversation

@rafaelcaricio
Copy link
Contributor

commented May 7, 2019

Fixes #523

@ilevkivskyi
Copy link
Collaborator

left a comment

Thanks, this looks good! As discussed off-line please add the same for multiple inheritance.

@ilevkivskyi
Copy link
Collaborator

left a comment

Great, this is ready to be merged when tests pass in CI.

@rafaelcaricio

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Thank you for the review @ilevkivskyi !

@ilevkivskyi ilevkivskyi merged commit 34993eb into python:master May 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafaelcaricio rafaelcaricio deleted the rafaelcaricio:name_mangling_ignore_methods branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.