When strict optional is disabled, anything can be falsey #6876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously some code was treated incorrectly as unreachable, since some checks where treated as always true even though they could be false given a None value. Fixes #6827.
ilevkivskyi
approved these changes
May 21, 2019
test-data/unit/check-namedtuple.test
Outdated
| if not a: | ||
| 1() # E: "int" not callable | ||
| b = (1, 2) | ||
| if not a: |
|
Update the target issue; it was pointing to an obsolete duplicate. |
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
Previously some code was treated incorrectly as unreachable, since some checks where treated as always true even though they could be false given a None value. Fixes python#3601.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously some code was treated incorrectly as unreachable, since
some checks where treated as always true even though they could
be false given a None value.
Fixes #3601.