Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error code arguments to plugin API #7323

Merged
merged 3 commits into from Aug 12, 2019

Conversation

@JukkaL
Copy link
Collaborator

commented Aug 12, 2019

Update some fail() methods to accept an error code argument.

@JukkaL JukkaL requested a review from ilevkivskyi Aug 12, 2019
Copy link
Collaborator

left a comment

LGTM!

Do we need a test case for how this is used in a plugin?

@JukkaL

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 12, 2019

Do we need a test case for how this is used in a plugin?

This would be nice, but I don't think that it's urgent. I'll create a follow-up issue.

@JukkaL JukkaL merged commit 6e75f9d into master Aug 12, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JelleZijlstra JelleZijlstra deleted the errcode-fail-arg branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.