Skip to content

Don't create incomplete __init__ signatures for deferred dataclasses #7382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

ilevkivskyi
Copy link
Member

Fixes #7250

Previously we just skipped attributes that are not ready, now we don't create an incomplete __init__() if possible, and if not possible (e.g. if attributes in some base classes are not ready) we allow updating plugin generated methods.

@ilevkivskyi ilevkivskyi merged commit 1e25e05 into python:master Aug 22, 2019
@ilevkivskyi ilevkivskyi deleted the fix-deferred-dataclass-sig branch August 22, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New analyzer reports error "Unexpected keyword argument" in dataclass
1 participant