Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aststrip deletion crash #7543

Merged
merged 1 commit into from Sep 21, 2019

Conversation

@msullivan
Copy link
Collaborator

msullivan commented Sep 20, 2019

Only delete from self.type.names if the key is actually in there.
I've included one test case that this fixes, though I suspect there
are others. Fixes #7238.

Only delete from self.type.names if the key is actually in there.
I've included one test case that this fixes, though I suspect there
are others. Fixes #7238.
@msullivan msullivan requested review from ilevkivskyi and JukkaL Sep 20, 2019
Copy link
Collaborator

ilevkivskyi left a comment

Makes sense!

@msullivan msullivan merged commit 959eb76 into master Sep 21, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@msullivan msullivan deleted the aststripcrash branch Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.