Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point incompatible assignment errors to rvalue instead of lvalue #7569

Merged
merged 3 commits into from Sep 27, 2019

Conversation

@JukkaL
Copy link
Collaborator

JukkaL commented Sep 27, 2019

This seems more logical. If there is a tuple lvalue, we point to the
incompatible tuple item.

Note that this may break some # type: ignore statements since
the reported line number may change (but it usually doesn't).

JukkaL added 3 commits Sep 5, 2019
This seems more logical. If there is a tuple lvalue, we point to the
incompatible tuple item.
Copy link
Collaborator

ilevkivskyi left a comment

Thanks, makes sense! Do we need a similar change to augmented assignments like x += y? (Maybe self.msg.incompatible_operator_assignment(s.op, s) call in visit_operator_assignment_stmt` needs to be updated.)

@JukkaL

This comment has been minimized.

Copy link
Collaborator Author

JukkaL commented Sep 27, 2019

Do we need a similar change to augmented assignments

They work like this already.

@JukkaL JukkaL merged commit e88ff4c into master Sep 27, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JelleZijlstra JelleZijlstra deleted the columns-4-assign branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.