Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some notes not being ignored when using an error code #7573

Merged
merged 5 commits into from Sep 27, 2019

Conversation

@JukkaL
Copy link
Collaborator

JukkaL commented Sep 27, 2019

Either change the error code to match the related error, so that
both will always be ignored at the same time, or switch a note to
an error (in case the relevant error code is hard to predict).

Fixes #7562.

@JukkaL JukkaL requested a review from ilevkivskyi Sep 27, 2019
Copy link
Collaborator

ilevkivskyi left a comment

👍

@JukkaL JukkaL merged commit 48c1e9b into master Sep 27, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JelleZijlstra JelleZijlstra deleted the errcode-notes branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.