Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[attrs] Support attr.s(eq=..., order=...) #7619

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@euresti
Copy link
Contributor

euresti commented Oct 3, 2019

attrs 19.2.0 added support for eq and order and deprecated to attr.s.
It also deprecated cmp.

Fixes #7615

attrs 19.2.0 added support for eq and order and deprecated to attr.s.
It also deprecated cmp.
Copy link
Collaborator

msullivan left a comment

Looks good! Thanks.

@msullivan msullivan merged commit 47093eb into python:master Oct 3, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator

ilevkivskyi commented Oct 4, 2019

Can this cause false positives for people who have an older version of attrs? If yes, this is probably something we should mention in the release notes probably.

@euresti

This comment has been minimized.

Copy link
Contributor Author

euresti commented Oct 4, 2019

Yes this will cause false positives for older versions of attrs. I don't know what the process for that normally is.

@belm0

This comment has been minimized.

Copy link

belm0 commented Oct 9, 2019

Following up on PR comment 47093eb#r35428812

Failing on deprecated API use doesn't seem in line with mypy's scope, and defeats Python's tried and true depreciation mechanisms.

The timing of say, when a project is forced to upgrade attrs due to a transitive dependency and when it's able to migrate it's own code off a deprecated API is often different due to policy and other constraints. The runtime deprecation mechanism and supporting tools allows projects to deal with this sanely.

@euresti

This comment has been minimized.

Copy link
Contributor Author

euresti commented Oct 10, 2019

Yep. It's been fixed. #7675

@belm0

This comment has been minimized.

Copy link

belm0 commented Oct 17, 2019

@euresti

Yep. It's been fixed. #7675

Well, but unfortunately the fix didn't make it into the new 0.740 release 😿

foo.py:23: error: cmp is deprecated, use eq and order

please have it patched...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.