Skip to content

Treat __class_getitem__ as an implicit classmethod like __init_subclass__ #7647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2019
Merged

Treat __class_getitem__ as an implicit classmethod like __init_subclass__ #7647

merged 2 commits into from
Oct 9, 2019

Conversation

AFanaei
Copy link
Contributor

@AFanaei AFanaei commented Oct 7, 2019

Fixes #7319

JukkaL
JukkaL reviewed Oct 8, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The fix looks good, I only have some comments about the tests.

JukkaL
JukkaL approved these changes Oct 9, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates -- looks good now!

@JukkaL JukkaL merged commit 46b159d into python:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

__class_getitem__ is not assumed to be a classmethod
2 participants
@AFanaei @JukkaL