Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat __class_getitem__ as an implicit classmethod like __init_subclass__ #7647

Merged
merged 2 commits into from Oct 9, 2019

Conversation

@AFanaei
Copy link
Contributor

AFanaei commented Oct 7, 2019

Fixes #7319

Copy link
Collaborator

JukkaL left a comment

Thanks for the PR! The fix looks good, I only have some comments about the tests.

test-data/unit/fixtures/implicit_class_method.pyi Outdated Show resolved Hide resolved
test-data/unit/check-super.test Outdated Show resolved Hide resolved
test-data/unit/fixtures/implicit_class_method.pyi Outdated Show resolved Hide resolved
@JukkaL
JukkaL approved these changes Oct 9, 2019
Copy link
Collaborator

JukkaL left a comment

Thanks for the updates -- looks good now!

@JukkaL JukkaL merged commit 46b159d into python:master Oct 9, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.