Skip to content

[attrs] Remove error message about deprecated cmp #7675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2019
Merged

[attrs] Remove error message about deprecated cmp #7675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96f6d5b
[Attrs] Remove deprecated error for cmp
euresti Oct 9, 2019
160f1f7
Fix the tests.
euresti Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mypy/plugins/attrs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ def _determine_eq_order(ctx: 'mypy.plugin.ClassDefContext') -> Tuple[bool, bool]

# cmp takes precedence due to bw-compatibility.
if cmp is not None:
ctx.api.fail("cmp is deprecated, use eq and order", ctx.reason)
return cmp, cmp

# If left None, equality is on and ordering mirrors equality.
Expand Down
6 changes: 3 additions & 3 deletions test-data/unit/check-attr.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,15 +278,15 @@ A(1) != 1

[case testAttrsCmpEqOrderValues]
from attr import attrib, attrs
@attrs(cmp=True) # E: cmp is deprecated, use eq and order
@attrs(cmp=True)
class DeprecatedTrue:
...

@attrs(cmp=False) # E: cmp is deprecated, use eq and order
@attrs(cmp=False)
class DeprecatedFalse:
...

@attrs(cmp=False, eq=True) # E: Don't mix `cmp` with `eq' and `order` # E: cmp is deprecated, use eq and order
@attrs(cmp=False, eq=True) # E: Don't mix `cmp` with `eq' and `order`
Copy link
Member

@ilevkivskyi ilevkivskyi Oct 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed the old-school quotes here :-) I mean `...' is great, but we are now moving towards unifying all error messages on using plain boring double quotes. So it would be great to update this (possibly in a separate PR).

class Mixed:
...

Expand Down