[mypyc] Support generating extension classes for dataclasses #7817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The approach here is to generate an extension class while also populating a dictionary with the appropriate fields for the dataclass constructor. Once the extension class is created, we swap out the contents of its `__dict__` with the `__dict__` that `dataclass` expects, invoke `dataclass`, and then put back all the original stuff. Fixes #671.
msullivan
force-pushed
the
dataclasses
branch
from
934c0e2 to
100d868
Compare
JukkaL
reviewed
Oct 30, 2019
|
|
||
| with assertRaises(TypeError, "missing 2 required positional arguments"): | ||
| Person1b() | ||
|
|
There was a problem hiding this comment.
What about testing that the class behaves like an extension class? Maybe try to monkeypatch and try to assign a value with an invalid type to an attribute (through attribute assignmend and constructor).
mypyc/genops.py
Outdated
| @@ -1459,6 +1460,12 @@ def dataclass_finalize( | |||
| (which will be descriptors) with whatever they would be in a | |||
| non-extension class, calling dataclass, then switching them back. | |||
|
|
|||
| The resulting class is an extension class and instances of it do not | |||
| does not have a __dict__ (unless something else requires it). | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach here is to generate an extension class while also
populating a dictionary with the appropriate fields for the dataclass
constructor. Once the extension class is created, we swap out the
contents of its
__dict__with the__dict__thatdataclassexpects, invoke
dataclass, and then put back all the original stuff.Fixes #671.