Skip to content

[mypyc] Speed up 'if x' for int values #9854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 30, 2020
Merged

[mypyc] Speed up 'if x' for int values #9854

merged 3 commits into from
Dec 30, 2020

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Dec 29, 2020

This speeds up the if_true microbenchmark by about 5%. Code size is also
reduced.

@JukkaL JukkaL requested a review from msullivan December 29, 2020 14:54
TH3CHARLie
TH3CHARLie approved these changes Dec 29, 2020
View reviewed changes
Copy link
Collaborator

@TH3CHARLie TH3CHARLie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@JukkaL JukkaL merged commit 4f3fcda into master Dec 30, 2020
@JukkaL JukkaL deleted the optimize-if-int branch December 30, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan Awaiting requested review from msullivan

1 more reviewer

@TH3CHARLie TH3CHARLie TH3CHARLie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JukkaL @TH3CHARLie