Report incompatible assignments for descriptors with overloaded __set__ methods. #9893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…__ methods (fixes python#7205). An assertion expected the second result of method `ExpressionChecker.check_call` to be a `CallableType`, but it is `AnyType` in the situation causing the crash. Hence, this commit replaces this assertion by handling both types differently. This involves modifying the second invocation of method `ExpressionChecker.check_call` a little to make sure it reports the invalid assignment in both cases. The new test case `testSettingDescriptorWithOverloadedDunderSet1` deals with overloading the value argument only and `testSettingDescriptorWithOverloadedDunderSet2` deals with overloading both the instance and the value argument.
JukkaL
reviewed
Jan 15, 2021
test-data/unit/check-classes.test
Outdated
| a = A() | ||
| a.f = '' | ||
| a.f = 1 | ||
| a.f = 1.5 |
There was a problem hiding this comment.
Can you add a # E comment here as a hint to the reader about where the error happens, like this:
a.f = 1.5 # E
(This is only a comment and has no semantic significance.)
test-data/unit/check-classes.test
Outdated
| b = B() | ||
| a.f = '' | ||
| b.f = 1 | ||
| a.f = 1 |
There was a problem hiding this comment.
Add # E comments to the lines that produce errors, similar to above.
mypy/checker.py
Outdated
| # And now we type check the call second time, to show errors related | ||
| # to wrong arguments count, etc. | ||
| # And now we in fact type check the call, to show errors related to wrong arguments | ||
| # count, etc., replacing the type context von non-overloaded setters only. |
There was a problem hiding this comment.
Glad I can help. Thanks for your remarks. I have adopted them as suggested.
|
Glad I can help. Thanks for your remarks. I have adopted them as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7205
Hello everyone,
this is my first contribution to mypy, I hope to meet your style well enough.
I added two test cases which cause mypy to crash without the provided changes. At least on my machine, the changes do not affect any other tests.
For short explanations, please see the commit message and the (modifications of the) inline comments.