Skip to content

Mandate that manylinux1 wheels be built without --with-fpectl #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2016
Merged

Mandate that manylinux1 wheels be built without --with-fpectl #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions pep-0513.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ This is a rather complex and subtle issue that extends beyond
the scope of ``manylinux1``; for more discussion see: [9]_, [10]_,
[11]_.


UCS-2 vs UCS-4 builds
---------------------

Expand Down Expand Up @@ -282,10 +283,30 @@ But you should never have a wheel with a name like::
PKG-VERSION-cp27-none-manylinux1_x86_64.whl
^^^^ BAD! Don't do this!

This wheel claims to be simultaneously compatible with *both* ucs2 and
ucs4 builds, which is bad.

We note for information that the ``ucs4`` ABI appears to be much more
widespread among Linux CPython distributors.


fpectl builds vs. no fpectl builds
----------------------------------

All extant versions of CPython can be built either with or without the
``--with-fpectl`` flag to ``configure``. It turns out that this
changes the CPython ABI: extensions that are built against a
no-``fpectl`` CPython are always compatible with yes-``fpectl``
CPython, but the reverse is not necessarily true. (Symptom: errors at
import time complaining about ``undefined symbol: PyFPE_jbuf``.) See:
[16]_.

For maximum compatibility, therefore, the CPython used to build
manylinux1 wheels must be compiled *without* the ``--with-fpectl``
flag, and manylinux1 extensions must not reference the symbol
``PyFPE_jbuf``.


Compilation of Compliant Wheels
===============================

Expand Down Expand Up @@ -600,6 +621,8 @@ References
(https://fedoraproject.org/wiki/Bundled_Software_policy)
.. [15] Debian Policy Manual -- 4.13: Convenience copies of code
(https://www.debian.org/doc/debian-policy/ch-source.html#s-embeddedfiles)
.. [16] numpy bug report:
https://github.com/numpy/numpy/issues/8415#issuecomment-269095235


Copyright
Expand Down