PEP 772: A round of updates #4320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain lines were wrapped incorrectly.
Instead of "expected", make it clear that the Steering Council "will" change their delegations.
There is a potential CoI around direct control over the funding that they would have approval power on.
This list needs to be written down before the PEP can be voted on / approved.
They might not want to become a voting member, or be appropriately available to do so.
pradyunsg
commented
Mar 24, 2025
warsaw
requested changes
Mar 25, 2025
AA-Turner
reviewed
Mar 25, 2025
hugovk
reviewed
Mar 25, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
warsaw
reviewed
Apr 10, 2025
There was a problem hiding this comment.
Added some suggestions based on the conversations. @pradyunsg please review/accept/reject and let's resolve the comment threads. Once the update is published, I'm happy to jumpstart the DPO thread with a summary of the revisions.
|
All commit authors signed the Contributor License Agreement. |
|
I'll follow up with another PR to address additional points. |
|
I think auto-merge is being prevented by Pradyun's CLA? |
Yeah, but I think that's bogus because @pradyunsg is a core dev. Is it GH or CLA-bot being weird? I'm probably just gonna override it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be best reviewed commit-by-commit.
📚 Documentation preview 📚: https://pep-previews--4320.org.readthedocs.build/