Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 571: Manylinux2 #565

Merged
merged 7 commits into from
Feb 6, 2018
Merged

PEP 571: Manylinux2 #565

merged 7 commits into from
Feb 6, 2018

Conversation

markrwilliams
Copy link
Contributor

manylinux1 needs an update. This is an attempt at a successor.

See pypa/manylinux#152, pypa/auditwheel#88, and pypa/pip#5008.

@brettcannon
Copy link
Member

Has this been discussed yet on distutils-sig or pypa-dev?

@markrwilliams
Copy link
Contributor Author

@brettcannon I have just sent an email to distutils-sig. I opened this PR so that GitHub would associate it with PRs I've opened against pypa/manylinux, pypa/auditwheel, and pypa/pip as a kind of umbrella for that work.

@brettcannon
Copy link
Member

Fair enough, but we typically don't accept PEPs into the repo that have not had at least one round of discussion on a public mailing list first (this is when we suggest people do the work on their personal fork first, then send the PR).

Because of that I'm going to close this PR for now, but I can re-open it once the PEP has gone through more public review.

@brettcannon brettcannon closed this Feb 1, 2018
@ofek
Copy link
Contributor

ofek commented Feb 1, 2018

@brettcannon We should consider this an escalated issue due to https://news.ycombinator.com/item?id=16277806. This week all manylinux1 images will no longer be able to access GitHub.

cc @trishankatdatadog

@brettcannon
Copy link
Member

@ofek Any escalation wouldn't be for here but for the people who will have to make the final decision of the PEP which would be distutils-sig.

@markrwilliams
Copy link
Contributor Author

@ofek Thanks for your interest! My PEP has made it to the distutils-sig mailing list, so let's discuss it there:
https://mail.python.org/pipermail/distutils-sig/2018-February/031944.html

@njsmith
Copy link
Contributor

njsmith commented Feb 3, 2018

@ofek It's not quite as bad as your comment makes it sounds – the GitHub change makes it more difficult to create the manylinux1 images, because they've relying on GitHub's lenient TLS policies to bootstrap themselves to a more secure setup. But users of the manylinux1 images are OK, because the curl and pythons we ship are all built using a modern openssl.

@ncoghlan ncoghlan self-assigned this Feb 6, 2018
@ncoghlan
Copy link
Contributor

ncoghlan commented Feb 6, 2018

Assigning to myself and reopening, since we've had an initial discussion on distutils-sig now :)

@ncoghlan ncoghlan reopened this Feb 6, 2018
@ncoghlan ncoghlan changed the title Manylinux2 PEP 571: Manylinux2 Feb 6, 2018
@ncoghlan ncoghlan merged commit a5f87a7 into python:master Feb 6, 2018
@markrwilliams markrwilliams deleted the manylinux2 branch February 8, 2018 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants