-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PEPs Contributing Guideline, CoC, and PR template #712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! But can we move the files to the top level (i.e. not inside .github
)? I'd like them to be a bit more discoverable when I do a plain ls
on the directory.
.github/contributing.rst
Outdated
|
||
To learn more about the purpose of PEPs and how to go about writing a PEP, please | ||
start reading at PEP 1 (pep-0001.txt in this repo). Note that PEP 0, the index PEP, | ||
is now automatically generated, and not committed to the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a (strong) suggestion added here to first discuss an idea on python-ideas before attempting to write a PEP.
Link to CONTRIBUTING.rst from README.rst
No prob! |
And if we find people continuing to forgot about the PEP number, I can write a bot to check for it 😄 |
What's the reason for keeping the other two in the .github subdir? In mypy we have ISSUE_TEMPLATE.md at the top level and it works fine. (I guess I am just in disagreement with GitHub's recommendation to hide these files from view.) |
The templates will work in both root level or inside .github. In my mind, the templates are really not relevant unless you're on GitHub web UI, opening an issue or PR, so I think these should remain in .github folder. But I can move the CoC to the root. |
Sorry. I see (for the first time now :-) that the cpython repo has a .github directory, so I withdraw my objection. I do think that the COC (here as well as there) belongs at the top level, since I would hope that people using the repo without using GitHub still ought to be reminded of the COC. |
Add CoC to contributing guidelines.
Moved Code_of_conduct.rst to root level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Follow up from python/peps#712 (comment): "people using the repo without using GitHub still ought to be reminded of the COC" - GvR
Follow up from python/peps#712 (comment): "people using the repo without using GitHub still ought to be reminded of the COC" - GvR
Follow up from python/peps#712 (comment): "people using the repo without using GitHub still ought to be reminded of the COC" - GvR
Closes #706