Remove unused var from fannkuch #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what the philosophy on changes to the benchmarks themselves is in this repo; the theory of this PR is that the benchmarks are intended to be reasonable representations of the most efficient way to accomplish a given (admittedly meaningless task) in Python with the correct result, and it doesn't make sense to have pure wasted work in the benchmarks. This `check` var is initialized and incremented, but never used, and plays no role in returning the correct result.
|
Thanks, @carljm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what the philosophy on changes to the benchmarks themselves is in this repo; the theory of this PR is that the benchmarks are intended to be reasonable representations of the most efficient way to accomplish a given (admittedly meaningless) task in Python with the correct result, and it doesn't make sense to have pure wasted work in the benchmarks.
This
checkvar is initialized and incremented, but never used, and plays no role in returning the correct result.