-
-
Notifications
You must be signed in to change notification settings - Fork 194
Allow for specifying local wheels and sdists as dependencies #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a352d6f
to
2d59043
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Could you add a test for this? I think a simple test with mock would suffice. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the most part this seems good. There is basically just one thing that's throwing me off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
197623f
to
88ce6f5
Compare
Had to go back to the drawing board on this approach, since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(and thanks for adding good tests)
It is useful, especially when creating custom versions of dependencies that are compatible with CPython main, to specify local file paths as dependencies. Unfortunately, that's blocked by a feature that treats any dependency that matches a file path as a requirements file. This makes that check a little more specific which allows for installing wheels.
This feels like the "safe" backward compatible change, but to be honest, I don't know why this feature exists in the first place -- it doesn't seem to be documented and the unit tests don't fail when you remove this whole
if
clause. I would also be ok with just removing thisif
clause if preferred.