Skip to content

Add coroutines benchmark #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2022
Merged

Add coroutines benchmark #217

merged 2 commits into from
Jun 18, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jun 16, 2022 •
edited
Loading

  • Add a benchmark for coroutines

Benchmark results:

Benchmark 3.10 3.12
coroutines 47.1 ms 34.8 ms: 1.35x faster

@kumaraditya303 kumaraditya303 marked this pull request as ready for review June 16, 2022 09:43
mdboom
mdboom requested changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great as a microbenchmark. Thanks.

gvanrossum
gvanrossum approved these changes Jun 18, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LG now.

pyperformance/data-files/benchmarks/bm_coroutines/pyproject.toml
dynamic = ["version"]

[tool.pyperformance]
name = "coroutines"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I guess eventually the microbenchmarks will need a tag they share, but that's not for this PR.)

@gvanrossum gvanrossum merged commit 053d36f into python:main Jun 18, 2022
@kumaraditya303 kumaraditya303 deleted the coroutines branch June 18, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdboom mdboom mdboom requested changes

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @mdboom @gvanrossum