-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a benchmark based on python -m pprint
#222
Conversation
This creative PR is a receiving half of python/cpython#94613. |
python -m pprint
python -m pprint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, Oleg! I've left some comments for you to consider.
pyperformance/data-files/benchmarks/bm_from_stdlib/pyproject.toml
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py
Outdated
Show resolved
Hide resolved
@ericsnowcurrently Thank you for your thorough feedback, I've addressed everything. In addition, I've also moved a class docstring into a file comment, and reworded it together with authorship. I hope I've made it right. Also I've added
Initially I've thought that a benchmark should be big, like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates.
This PR couples with python/pyperformance#222 and supersedes #92560. Inspired by #93096 (comment). Automerge-Triggered-By: GH:ericsnowcurrently
python -m pprint
should have tests or not.After merging, python/cpython#92546 needs to be closed.