no-issue: Add free-threading CI #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corona10
changed the title
corona10
force-pushed
the
free-threading
branch
3 times, most recently
from
847150b to
22adc00
Compare
hugovk
reviewed
May 11, 2024
corona10
changed the title
|
@hugovk |
|
Sorry my local force push up ignore your previous comment :( |
corona10
commented
May 11, 2024
| @@ -25,44 +25,54 @@ jobs: | |||
| os: [ubuntu-latest] | |||
| python: ["3.8", "3.9", "3.10", "3.11", "3.12"] | |||
| experimental: [false] | |||
| build: [''] | |||
There was a problem hiding this comment.
OTAH, what do you think about using 'default'?
(It could be verbose for someone)
There was a problem hiding this comment.
Yeah, that could work. I've no strong opinion either way :)
hugovk
approved these changes
May 11, 2024
| - name: Install | ||
| # pyperformance must be installed: | ||
| # pyperformance/tests/test_compare.py imports it | ||
| run: | | ||
| python -m pip install --upgrade pip setuptools | ||
| python -m pip install -e . | ||
| - name: Display Python version | ||
| run: python -c "import sys; print(sys.version)" | ||
| run: python --version --version |
There was a problem hiding this comment.
It's a shame this doesn't show if we're on a free-threaded build, but never mind.
| @@ -25,44 +25,54 @@ jobs: | |||
| os: [ubuntu-latest] | |||
| python: ["3.8", "3.9", "3.10", "3.11", "3.12"] | |||
| experimental: [false] | |||
| build: [''] | |||
There was a problem hiding this comment.
Yeah, that could work. I've no strong opinion either way :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference: https://dev.to/hugovk/help-us-test-free-threaded-python-without-the-gil-1hgf